Code Improvements for Script Updates#379
Conversation
Code improvements when checking for available script updates and performing automatic script updates.
|
Well, I decided to implement the code early this morning (while I had it fresh in my mind) before getting busy with other "stuff" for the rest of the day, where I might not be able to get away with some free time as the day starts coming to a close later in the afternoon. Anyway, the goal was that when the future 1.4.0 version is eventually released "into the wild" the then-current 1.3.9 version (or perhaps even a later 1.3.10 release, if needed), will work with the following scenarios:
The above call will go through the same steps as in the 1st scenario when the 1.4.0 script version is downloaded; otherwise, the code will behave the same as before (e.g. say, you call "force update" to re-install the 1.3.9 version for some reason). Please take a look and test/verify when you get a chance. Enjoy the New Year's Eve celebration, bud!! |
|
Approved! Happy new years buddy! |
|
I follow the logic, basically if the version matches the 1.4.0 version then it will execute a special routine to use the forceupdate parameter, otherwise it's basically the regular process, where the user can force update the same version. Like you mentioned we can call this special routine using the new parameter called: newgui from the external "forceupdate" entry point :) |
I was just about to submit some code improvements to this PR. My apologies, I should have sent you a message once I started to make further changes to the PR. I was just doing some testing while my wife is getting ready for tonight (we're going to my brother's house for New Year's Eve), and found a couple of areas that needed some fine-tuning. Well, no worries; I'll just submit a new PR. |
Darn it Martinski! Communication! 😉😂 I haven't tested your changes yet but I reviewed them just to follow the logic and make sure I was on the same page. I was going to test them once the count down was over 😉 I got a beer in hand so testing will be on the back burner for the next few hours hehehe Only got 3 hours to go! More like 6 hours for you? |
Yes, exactly. Once the new future "1.4.0" release is issued, we can let users know of the required manual update call in case they don't have "Automatic Script Updates" enabled; otherwise, the auto-update feature should take care of it transparently. |
Yeah, there's no rush. I didn't think you were going to merge the PR this evening, so I thought I had some time until tomorrow, LOL!!! Anyway, take your time, bud. Enjoy the evening and relax. Tomorrow will still be there.
Yep, about 6 hours. I'll be signing off in a few minutes myself. |
I keep you guessing it's all good 😉
I shall wish you a happy new year! In case you aren't around at midnight! Enjoy the celebration 🎉 I myself am having a pretty relaxed night but I do have a beer in hand, a nice steak cooking as we speak, and will watch some fireworks in a bit. Hopefully all things you WOULD do 🥳 |
Code improvements when checking for available script updates and performing automatic script updates.